Fix warning on conversion of anon func with implicit parameters #59522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
force-pushed
the
implicit-parameters
branch
from
ab718e7
to
8bd26e5
Compare
jcouv
force-pushed
the
implicit-parameters
branch
from
8bd26e5
to
cb33d99
Compare
cston
reviewed
Feb 14, 2022
cston
reviewed
Feb 14, 2022
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs
Show resolved
Hide resolved
cston
approved these changes
Feb 14, 2022
RikkiGibson
reviewed
Feb 15, 2022
| @@ -1357,7 +1356,6 @@ internal sealed class PlainUnboundLambdaState : UnboundLambdaState | |||
| _isStatic = isStatic; | |||
| } | |||
|
|
|||
| public override bool HasNames { get { return !_parameterNames.IsDefault; } } | |||
There was a problem hiding this comment.
so this member was just totally redundant in practice?
There was a problem hiding this comment.
Yup, they have the same meaning. We had HasNames, HasSignature and I was adding yet another one...
RikkiGibson
approved these changes
Feb 15, 2022
jcouv
changed the title
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59336